New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read-Only Filesystem while sending #1

Open

pierew wants to merge 2 commits into nazar-pc:master from pierew:patch-1

pierew commented Jan 9, 2018

new btrfs version needs a read-only filesystem for sending

Piere Wöhl added 2 commits

January 9, 2018 23:10


          Read-Only Filesystem while sending

c10b522

new btrfs version needs a read-only filesystem for sending


          Update btrfs-sync-subvolumes

517eabb

Owner

nazar-pc commented Jan 10, 2018

Interesting, I've only used it for read-only subvolumes.

I like the idea, however:

please keep indentation with tabs instead of spaces (configure editor to display 1 tab as 4 spaces, GitHub uses 8, hence code looks awful)
code needs to first check property on subvolume and only change it if needed (in other words, all my read-only subvolumes will become writable with this change, which is unexpected behavior)

nazar-pc added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment