Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix direction of willChange event when circular #856

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

malangfox
Copy link
Contributor

Issue

#854

Details

This fixes the behavior of getDirection, fixing cases where the direction of the willChange event is incorrect.

@coveralls
Copy link

Coverage Status

coverage: 82.684% (+0.05%) from 82.638%
when pulling 5e9d8d3 on malangfox:fix/willchange-circular-direction
into 3d52804 on naver:master.

Copy link
Member

@daybrush daybrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malangfox malangfox merged commit 022546a into naver:master Mar 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants