fix: fix broken layout when direction rtl is applied #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daybrush
reviewed
Nov 14, 2023
src/Flicking.ts
Outdated
| @@ -1511,6 +1520,7 @@ class Flicking extends Component<FlickingEvents> { | |||
| camera.updateAdaptiveHeight(); | |||
| camera.updateOffset(); | |||
| await renderer.render(); | |||
| this._updatePanelOrder(camera); | |||
There was a problem hiding this comment.
I think it would be better to move to the camera class method.
There was a problem hiding this comment.
I have modified updatePanelOrder to camera class method.
You can check the most recent commit.
updatePanelOrder requires flicking.control.controller.updateDirection(); to be called.
Should this be the camera class method, even though it interferes with flicking's controller?
malangfox
force-pushed
the
fix-direction-rtl
branch
from
583246d
to
25b505e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#835
Details
This issue fixes the layout breaking when
direction: rtlis applied to the viewport.