INTERNAL: Fix a sprintf error and remove a needless condition #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhpark816
reviewed
May 7, 2024
| @@ -1509,7 +1509,7 @@ static void pipe_response_done(conn *c, bool end_of_pipelining) | |||
| str = "PIPE_ERROR bad error\r\n"; | |||
| len = 22; | |||
| } | |||
| sprintf(c->pipe_resbuf + c->pipe_reslen, str); | |||
There was a problem hiding this comment.
@ing-eoking
이거 내가 실수한 거네요.
Thanks.
namsic
reviewed
May 7, 2024
|
@namsic 나도 그렇게 생각하다가, 간단한 수정이라 그냥 merge해 버렸습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⌨️ What I did