CLEANUP: Refactor methods of setting ritems #747
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ing-eoking
force-pushed
the
ritem
branch
2 times, most recently
from
26fb268
to
2470626
Compare
This comment was marked as resolved.
This comment was marked as resolved.
namsic
reviewed
Mar 26, 2024
ing-eoking
force-pushed
the
ritem
branch
2 times, most recently
from
ef3e0ff
to
f1ab61b
Compare
namsic
approved these changes
Mar 27, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ing-eoking
force-pushed
the
ritem
branch
8 times, most recently
from
eed606d
to
414953c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
지금 구현 기준으로는 protocol 간 코드 차이가 거의 없어서 분리하지 않아도 될 것 같습니다. |
ing-eoking
force-pushed
the
ritem
branch
3 times, most recently
from
3d70157
to
94ad2a4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ing-eoking
force-pushed
the
ritem
branch
9 times, most recently
from
fc548b5
to
cb5ce60
Compare
This comment was marked as resolved.
This comment was marked as resolved.
jhpark816
reviewed
Apr 5, 2024
ing-eoking
force-pushed
the
ritem
branch
2 times, most recently
from
77ba1ea
to
a4f8c9d
Compare
|
2차 수정되었습니다. |
ing-eoking
force-pushed
the
ritem
branch
2 times, most recently
from
d99d920
to
9dab785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
rlist를 추가했습니다.ritem_set_first/ritem_set_next,RTYPE를 제거했습니다.add_ritem/add_ritem_mblck/add_ritem_einfo/add_ritem_hinfo를 추가했습니다.rlist의 메모리 부족 처리를 추가하면서 일부 에러 핸들링을 아래의 PR처럼 통일시켰습니다.