REFACTOR: addedQ poll logic in handleInputQueue. #832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhm0311
requested changes
Oct 18, 2024
| @@ -825,45 +825,42 @@ private void handleDelayedSwitchover() { | |||
|
|
|||
| // Handle any requests that have been made against the client. | |||
| private void handleInputQueue() { | |||
| if (!addedQueue.isEmpty()) { | |||
There was a problem hiding this comment.
๊ธฐ์กด์๋ addedQueue.isEmpty()์ธ ๊ฒฝ์ฐ ์๋ฌด๋ฐ ๋ก์ง์ ์ํํ์ง ์์์ต๋๋ค.
ํ์ฌ๋ ์ผ๋ถ ๊ฐ์ฒด๋ฅผ ์์ฑํด์ผ ํฉ๋๋ค.
addedQueue.isEmpty() == true์ธ ๊ฒฝ์ฐ ํจ์๋ฅผ ๋น ์ ธ๋๊ฐ๋๋ก returnํ๋ ์กฐ๊ฑด๋ฌธ์ ์ถ๊ฐํฉ์๋ค.
|
@brido4125
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Related Issue
โจ๏ธ What I did
addedQueue๋ก๋ถํฐ poll์ ํด์ค๋ ๋ก์ง์ ๋ฆฌํฉํ ๋ง ํ์์ต๋๋ค.
while ๋ฃจํ์์๋ง ์ฌ์ฉ๋๋ node๋ผ๋ ์ง์ญ๋ณ์ ์ ๊ฑฐํ๊ณ
addedQueue.poll() != null์ ํตํด ํ๊ฐ ๋น์ด์๋์งํ์ธํ๋ ๋ก์ง์ isEmpty๋ก ์ฒ๋ฆฌํ์ฌ ์ฝ๊ธฐ ์ฝ๊ฒ ๋ฐ๊ฟจ์ต๋๋ค.