INTERNAL: Refactor transcoder compress logic. #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhm0311
requested changes
Nov 10, 2023
src/main/java/net/spy/memcached/transcoders/BaseSerializingTranscoder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/spy/memcached/transcoders/SerializingTranscoder.java
Outdated
Show resolved
Hide resolved
brido4125
force-pushed
the
refactor/transcoder
branch
from
22b7d99 to
c5d5e94
Compare
uhm0311
requested changes
Nov 10, 2023
src/main/java/net/spy/memcached/transcoders/BaseSerializingTranscoder.java
Show resolved
Hide resolved
src/main/java/net/spy/memcached/transcoders/WhalinV1Transcoder.java
Outdated
Show resolved
Hide resolved
brido4125
force-pushed
the
refactor/transcoder
branch
from
c5d5e94 to
798b7d1
Compare
uhm0311
requested changes
Nov 10, 2023
src/main/java/net/spy/memcached/transcoders/BaseSerializingTranscoder.java
Show resolved
Hide resolved
src/test/java/net/spy/memcached/transcoders/BaseSerializingTranscoderTest.java
Outdated
Show resolved
Hide resolved
brido4125
force-pushed
the
refactor/transcoder
branch
from
798b7d1 to
a9fa708
Compare
uhm0311
reviewed
Nov 10, 2023
src/main/java/net/spy/memcached/transcoders/BaseSerializingTranscoder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/spy/memcached/transcoders/BaseSerializingTranscoder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/spy/memcached/transcoders/GzipCompressor.java
Outdated
Show resolved
Hide resolved
brido4125
force-pushed
the
refactor/transcoder
branch
from
a9fa708 to
9dffd6e
Compare
uhm0311
approved these changes
Nov 13, 2023
uhm0311
requested changes
Nov 13, 2023
brido4125
force-pushed
the
refactor/transcoder
branch
from
9dffd6e to
f8fb757
Compare
uhm0311
approved these changes
Nov 14, 2023
uhm0311
force-pushed
the
develop
branch
2 times, most recently
from
07918e6 to
ae2a82f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/jam2in/arcus-works/issues/453
위 이슈에 언급된 것처럼 현재 Transcoder는 너무 많은 관심사를
하나의 클래스가 가지고 있습니다.
점진적으로 관심사들을 분리하는 작업을 진행할 예정입니다.
해당 PR은 compress 로직을
Compressior라는 클래스가 수행하도록 변경하였습니다.