[FIXED] (2.11) Respect consumer's starting seq, even if in the future #6253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauriceVanVeen
force-pushed
the
maurice/consumer-respect-start-seq
branch
from
6902961 to
a1d3f00
Compare
MauriceVanVeen
force-pushed
the
maurice/consumer-respect-start-seq
branch
2 times, most recently
from
31b599f to
900fd35
Compare
|
What's the status of this one? |
Signed-off-by: Maurice van Veen <[email protected]>
MauriceVanVeen
force-pushed
the
maurice/consumer-respect-start-seq
branch
from
900fd35 to
ddcc364
Compare
It's ready for review. |
|
Looking at your comment here @neilalexander #6005 (comment):
Maybe we should leave this for 2.11? |
|
Yes should be for 2.11. |
MauriceVanVeen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a replicated stream a consumer with a starting sequence could be created on a follower that's ever so slightly behind on applies. If the starting sequence is higher than the stream's last sequence we would clamp it down.
We should not be clamping it down, and must respect what the user/client gave us. That ensures any messages the user/client gets are always
message.seq>=starting_seqas well.However, if the consumer is used for mirroring/sourcing then we should still clamp down.
Signed-off-by: Maurice van Veen [email protected]