Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy CRDs into the crds directory of the NACK chart #694

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Copy CRDs into the crds directory of the NACK chart #694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ccff62
Add `crds.yml` to special `crds` folder in the Nack helm chart
dfr-exnaton Apr 2, 2023
51e88f6
Update README with dedicated section on CRDs and upgrading a helm cha…
dfr-exnaton Apr 3, 2023
5f75ec0
Move CRD upgrad to extra test step
dfr-exnaton Apr 3, 2023
1792031
Revert formatting changes
dfr-exnaton Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,11 @@ jobs:

- name: Run chart-testing (install)
run: |-
sudo microk8s.kubectl apply -f https://raw.githubusercontent.com/nats-io/nack/main/deploy/crds.yml
ct install \
--all \
--chart-dirs helm/charts \
--excluded-charts nats-account-server,nats-kafka,nats-operator,surveyor

- name: Run chart-testing (CRD upgrade)
run: |-
sudo microk8s.kubectl apply -f https://raw.githubusercontent.com/nats-io/nack/main/deploy/crds.yml
13 changes: 9 additions & 4 deletions helm/charts/nack/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
## TL;DR;

```console
# First, need to install the CRDs manually.
kubectl apply -f https://raw.githubusercontent.com/nats-io/nack/v0.6.0/deploy/crds.yml

helm repo add nats https://nats-io.github.io/k8s/helm/charts/
helm install nats nats/nats
helm install nack-jsc nats/nack --set jetstream.nats.url=nats://nats:4222
Expand Down Expand Up @@ -43,7 +40,7 @@ natsbox:
helm install nats nats/nats -f deploy-nats.yaml
```

Now install the JetStream CRDs and Controller. In case of using credentials, you need to make them available as a secret:
Now install the JetStream Controller. In case of using credentials, you need to make them available as a secret:

```sh
kubectl create secret generic nats-user-creds --from-file ./nsc/nkeys/creds/KO/JS1/js.creds
Expand Down Expand Up @@ -160,6 +157,14 @@ delivered: 1 / consumer seq: 2 / stream seq: 2 / ack: false
order 2
```

### CRDs & upgrading the chart version

As part of the Helm chart, CRDs are installed. Should you update the underlying NACK version through an Chart version update, you might want to reapply the CRDs as Helm is not updating CRDs during an upgrade:

```
kubectl apply -f https://raw.githubusercontent.com/nats-io/nack/v0.6.0/deploy/crds.yml
```

### Local Development

```sh
Expand Down
Loading