Fix CloudFormation StackSet creation when deployed to the management account #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the CloudFormation StackSet deployment module to work when deployed to an AWS management account by dynamically setting the call_as parameter based on the deployment context.
- Adds organization management account ID to the current context variable
- Conditionally sets
call_asto "SELF" when deployed to management account, otherwise "DELEGATED_ADMIN"
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| modules/service-deployment/variables.tf | Adds organization_management_account_id field to current variable structure |
| modules/service-deployment/cloudformation.tf | Updates call_as parameter logic for both StackSet and StackSet instances resources |
| main.tf | Retrieves organization management account ID and passes it to the deployment module |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kurtismash
force-pushed
the
fix/management-account-deployment
branch
from
854609c to
cecdc1c
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kurtismash
force-pushed
the
fix/management-account-deployment
branch
from
cecdc1c to
70e671e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although our documented advice is to deploy this to a dedicated backup account, it's likely some will want to deploy this to their management account. Sets the
call_asargument on theaws_cloudformation_stack_setandaws_cloudformation_stack_instancestoSELFwhen deployed to the management account.