Support pymodbus 3.4.1 #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HA has upgraded the version it uses. Since we specify a lower version, if there are any other integrations which use the higher version we'll race to see which gets installed first, so there's a chance that we'll end up with 3.4.1. This matters, because 3.4.1 doesn't have automatic (re)connections. Fix this. Also relax our range to >=3.1.3, so that if HA upgrades its version again we'll deterministically get the newer version, and if there's a problem we'll know about it, rather than being in a sometimes-working state. Fixes: nathanmarlor#393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HA has upgraded the version it uses. Since we specify a lower version, if there are any other integrations which use the higher version we'll race to see which gets installed first, so there's a chance that we'll end up with 3.4.1.
This matters, because 3.4.1 doesn't have automatic (re)connections.
Fix this. Also relax our range to >=3.1.3, so that if HA upgrades its version again we'll deterministically get the newer version, and if there's a problem we'll know about it, rather than being in a sometimes-working state.
Fixes: #393