Migrate old invalid entity ID prefixes #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canton7
force-pushed
the
bugfix/invalid-entity-id-prefix
branch
2 times, most recently
from
e41eee8
to
7a0b2a7
Compare
This is confusing the charge period card. This change also opens the door to us letting people reconfigure the friendly name and entity id prefix, as this now won't change the unique id. Fixes: nathanmarlor#382
canton7
force-pushed
the
bugfix/invalid-entity-id-prefix
branch
from
7a0b2a7
to
b4f9841
Compare
|
We should make sure that we don't end up with duplicate unique ids. I'm not sure whether it's possible currently... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is confusing the charge period card.
This change also opens the door to us letting people reconfigure the friendly name and entity id prefix, as this now won't change the unique id.
Fixes: #382