Skip to content

Commit

Permalink
Merge pull request #487 from canton7/bugfix/entity-metaclass
Browse files Browse the repository at this point in the history
Fix breakage caused by ABCCachedProperties metaclass on Entity
  • Loading branch information
canton7 committed Jan 6, 2024
2 parents 1d4b8ae + 75bb87f commit ebd3671
Showing 1 changed file with 16 additions and 1 deletion.
17 changes: 16 additions & 1 deletion custom_components/foxess_modbus/entities/modbus_entity_mixin.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
"""Mixin providing common functionality for all entity classes"""
import logging
from abc import ABC
from typing import TYPE_CHECKING
from typing import Any
from typing import Protocol
Expand Down Expand Up @@ -73,8 +74,22 @@ class ModbusEntityProtocol(Protocol):
else:
_ModbusEntityMixinBase = object

# HA introduced a ABCCachedProperties metaclass which is used by Entity, and which derives from ABCMeta.
# This conflicts with Protocol's metaclass (from ModbusEntityProtocol).
if type(Entity) == type(ABC):
_METACLASS = type(Entity)

class ModbusEntityMixin(ModbusControllerEntity, ModbusEntityProtocol, _ModbusEntityMixinBase):
else:

class ModbusEntityMixinMetaclass(type(Entity), type(Protocol)): # type: ignore
pass

_METACLASS = ModbusEntityMixinMetaclass


class ModbusEntityMixin(
ModbusControllerEntity, ModbusEntityProtocol, _ModbusEntityMixinBase, metaclass=_METACLASS # type: ignore
):
"""
Mixin for subclasses of Entity
Expand Down

0 comments on commit ebd3671

Please sign in to comment.