Skip to content

Commit

Permalink
Modified params to be compated as strings (#274)
Browse files Browse the repository at this point in the history
Instead of comparing parameters from the conf and api directly
convert both to lowercase string to avoid type problems

Closes #273
  • Loading branch information
EliadCohen authored Jun 28, 2023
1 parent bd8cddc commit 86af58d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion jeeves/jobs.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def get_jenkins_job_info(server, job_name, filter_param_name=None, filter_param_
break
if filter_param_name is not None:
api_param_value = [param['value'] for param in build_parameters if filter_param_name == param.get('name', '')][0]
if api_param_value == filter_param_value:
if str(api_param_value).lower() == str(filter_param_value).lower():
break
if build_info['previousBuild'] is None:
raise Exception("No filter match")
Expand Down

0 comments on commit 86af58d

Please sign in to comment.