Implement String#[]= and MatchData#offset #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardboehme
force-pushed
the
string-refeq
branch
from
d051c2a to
2b3ef6f
Compare
|
Hey @seven1m, can you figure out why those specs are failing? There seems to be a compilation error in one batch of specs related to symbols. I could fix this by adding |
|
Yeah I'll take a look. I will be removing the spec batching mechanism from the suite because I ran into a similar problem yesterday -- specs producing weird behavior when combined. |
|
Looks like ungrouping the specs fixed it. Merge at will! |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#217]