Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix defined? to not call const_missing #2309

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Fix defined? to not call const_missing #2309

merged 2 commits into from
Nov 8, 2024

Commits on Nov 8, 2024

  1. Do not call const_missing when using defined?

    @richardboehme
    richardboehme committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    1aaeb26 View commit details
    Browse the repository at this point in the history

  2. Fix conditional constant assignment with const_missing 

    This was previously broken because we used a defined instruction that
was calling `const_missing` and thus did not set the constant.

We now use the new `ConstLookupFailureMode::Raise` to ensure that the
lookup for the constant raises which in turn leads to the constant
being assigned correctly.
    @richardboehme
    richardboehme committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    23ed3f0 View commit details
    Browse the repository at this point in the history