Start work on String#byteindex #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herwinw
reviewed
Jun 29, 2024
seven1m
force-pushed
the
string-byteindex
branch
from
a8d2145 to
a356ed3
Compare
CRuby is inconsistent. Sometimes it raises an error messages like this:
no implicit conversion from nil to string
...and other times it raises this:
no implicit conversion of nil into String
The latter is more consistent with other error messages, and I hope that
someday CRuby is self-consistent. For now, though, to make things
spec-compliant, we have:
| method | error message style |
|========================|=====================|
| Env::raise_type_error | old |
| Env::raise_type_error2 | new |
| Object::to_str | old |
| Object::to_str2 | new |
I'll add support for a Regexp argument later.
seven1m
force-pushed
the
string-byteindex
branch
from
a356ed3 to
1d19c7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#217