Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support file and line arguments in eval #2138

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Support file and line arguments in eval #2138

wants to merge 5 commits into from

Commits on Jun 24, 2024

  1. Don't show "binding passed to eval will be ignored" for explicit nil … 

    …argument

Since this is done at compile time, we can only warn for an explicit nil
statement, not for expressions. This argument can be explicit nil if the
caller wants to add file/line arguments (arguments 2 and 3).
    @herwinw
    herwinw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e125c67 View commit details
    Browse the repository at this point in the history

  2. Update specs for binding 

    We can run the specs, but they fail. Catch this in a NATFIXME block
instead of removing the code.
    @herwinw
    herwinw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c086dd5 View commit details
    Browse the repository at this point in the history

  3. Add specs for file and line arguments in eval calls

    @herwinw
    herwinw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    8db6b80 View commit details
    Browse the repository at this point in the history

  4. Support file argument in eval

    @herwinw
    herwinw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    20782e9 View commit details
    Browse the repository at this point in the history

  5. Support line argument in eval

    @herwinw
    herwinw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    179f7f3 View commit details
    Browse the repository at this point in the history