Make String#dup spec-compliant #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for internal use. I'll work on making Kernel#dup more correct next.
I just noticed this when thinking through Ruby's initialize_copy semantics. This was no doubt a memory leak.
This was returning false if the integer or double had been turned into a "real" object.
This blog post helped me better understand how dup, initialize_dup, initialize_clone, and initialize_copy behave: https://jonleighton.name/2011/initialize_clone-initialize_dup-and-initialize_copy-in-ruby/ This only fixes Kernel#dup for String, for now, but sets us up to get all the classes dup'ing properly in the future.
I use it like this:
GLOB='spec/**/dup_spec.rb' DEBUG=true \
ruby test/ruby/ruby_specs_test.rb
...so I can see debugging output when the specs are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#217
I had to go down a rabbit trail on this one to figure out how
Kernel#dupworks along withinitialize_dupandinitialize_copy. This blog post was helpful: https://jonleighton.name/2011/initialize_clone-initialize_dup-and-initialize_copy-in-ruby/