refactor PlayerLaneHandler and PlayerMovement for improved lane chang… #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e logic; add checks for jumping and sliding states
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes aimed at improving the player movement and lane handling logic in the game. The most important changes include the introduction of new methods to check player states, the refactoring of state variables to properties, and the addition of a warning message for component dependencies.
Improvements to player movement and lane handling logic:
Assets/Scripts/player/PlayerLaneHandler.cs: AddedcanChangeLaneandisTurningmethods to improve the readability and maintainability of the lane change logic. [1] [2] [3]Refactoring of state variables to properties:
Assets/Scripts/player/PlayerMovement.cs: RefactoredisJumpingandisSlidingvariables to properties (IsJumpingandIsSliding) to encapsulate the state management and improve code clarity. [1] [2] [3] [4]Additional warning for component dependencies:
Assets/Scripts/player/PlayerTurnHandler.cs: Added a warning message in theStartmethod to notify if thePlayerLaneHandlercomponent is missing, ensuring proper component dependencies.