Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an 'externally contributed' column to the datasets #100

Merged
merged 4 commits into from
Aug 12, 2022
Merged

Add an 'externally contributed' column to the datasets #100

merged 4 commits into from
Aug 12, 2022

Conversation

gabrieltseng
Copy link
Collaborator

@gabrieltseng gabrieltseng commented Aug 3, 2022 •
edited
Loading

  • Add an externally contributed column to the dataset
  • Allow datasets to be filtered against this attribute
  • Update the labels.geojson on Zenodo (causing the failing integration test)

Blocks #99

ivanzvonkov
ivanzvonkov reviewed Aug 3, 2022
View reviewed changes
cropharvest/datasets.py Outdated Show resolved Hide resolved
ivanzvonkov
ivanzvonkov approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@ivanzvonkov ivanzvonkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved so long as the tests pass when zenodo is updated

@gabrieltseng gabrieltseng merged commit fa80888 into main Aug 12, 2022
@gabrieltseng gabrieltseng deleted the contributed branch August 12, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanzvonkov ivanzvonkov ivanzvonkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrieltseng @ivanzvonkov