Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed one warning message at shutdown after checkpoint load and kept the current multicast group after checkpoint load. #1784

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

hchen99
Copy link
Contributor

@hchen99 hchen99 commented Sep 19, 2024

  1. When an external app such as the sim control panel is configured as following in the input file, the corresponding destructor gets called at the shutdown. In turn, the MM will try to clean the memory for the vars related to the external app even those vars were already taken care of due to the shutdown. Thus there was a warning message.
    simControlPanel = trick.SimControlPanel()
    trick.add_external_application(simControlPanel)
    However, if having trick.sim_control_panel_set_enabled(True) in the input file, there was no warning message.

Deleted the unnecessary command c str pointer, thus removed the need to free its memory allocation as before.

  1. Made sure that the multicast group is not initialized before calling a function to initialize it in VariableServerListenThread.cpp. Without the check, trick-sniffer wouldn't find the sim anymore after loading a checkpoint as the multicast group got initialized again even it was already initialized.

…tructor;

Made sure that the MulticastGroup is not initialized before initializing it in VariableServerListenThread.cpp;
@coveralls
Copy link

coveralls commented Sep 19, 2024

Coverage Status

coverage: 55.83% (-0.06%) from 55.892%
when pulling c1f4af1 on fix-two-warning-messages-related-to-checkpoint-load
into eed8707 on master.

@sharmeye sharmeye merged commit 077064f into master Sep 26, 2024
13 checks passed
@sharmeye sharmeye deleted the fix-two-warning-messages-related-to-checkpoint-load branch September 26, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants