Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated import with numpy array to handle dictionaries with values th… #523

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mstraut
Copy link
Contributor

@mstraut mstraut commented Apr 21, 2023

added "from numpy import array" for dictionaries that contain numpy arrays as values.

@github-actions
Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@github-actions
Copy link

Benchmarking Results
From:

Test Time (s)
import main 0.12664140000000002
import thrown object 0.5045667
model initialization 0.11867319999999992
set noise 0.6465742999999999
simulate 0.2963146000000001
simulate with saving 0.9083089000000002
simulate with saving, dt 1.0312188999999998
simulate with printing results, dt 1.2533236000000008
Plot results 14.0633556
Metrics 0.03955500000000001
Surrogate Model Generation 3.187792299999998
surrogate sim 1.0002384999999983
surrogate sim, dt 2.8838846999999994
To:
Test Time (s)
--- ---
import main 0.12649310000000002
import thrown object 0.5026661000000001
model initialization 0.11567599999999989
set noise 0.6439137000000001
simulate 0.29685309999999987
simulate with saving 0.9149403999999999
simulate with saving, dt 1.0255864999999997
simulate with printing results, dt 1.2560729999999998
Plot results 14.1570844
Metrics 0.03970389999999924
Surrogate Model Generation 3.2682083000000013
surrogate sim 1.004453999999999
surrogate sim, dt 2.889538599999998

@codecov-commenter
Copy link

Codecov Report

Merging #523 (94af910) into dev (f89fb9b) will decrease coverage by 1.59%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #523      +/-   ##
==========================================
- Coverage   80.77%   79.18%   -1.59%     
==========================================
  Files          53       30      -23     
  Lines        6074     2369    -3705     
==========================================
- Hits         4906     1876    -3030     
+ Misses       1168      493     -675     
Impacted Files Coverage Δ
src/prog_models/utils/containers.py 85.71% <100.00%> (+0.18%) ⬆️

... and 23 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@matteocorbetta matteocorbetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, since the DictLikeMatrixWrapper will be completely different in a week! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants