Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prog models feature/cleanup/test sim result #500

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

mstraut
Copy link
Contributor

@mstraut mstraut commented Feb 27, 2023

housekeeping: cleaned up variables, updated imports.

test_sim_result.py
test_sim_result.py

fixed containers.py imports
@mstraut mstraut requested a review from teubert February 27, 2023 20:56
@github-actions
Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All tests must be passing.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@mstraut mstraut marked this pull request as draft February 27, 2023 22:35
@mstraut mstraut marked this pull request as ready for review February 27, 2023 22:50
@mstraut mstraut marked this pull request as draft February 27, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant