-
Notifications
You must be signed in to change notification settings - Fork 60
HARMONY-2186: Update memory limit for OPERA_RTC_S1_BROWSE #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughIncreased OPERA_RTC_S1_BROWSE_LIMITS_MEMORY from 512Mi to 2Gi, added a 2025-10-23 changelog entry documenting that change, and inserted a new top-level exemption entry "1109241" into multiple Changes
Sequence Diagram(s)Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
ENV_CHANGELOG.md (1)
5-8: LGTM with minor grammar suggestion.The changelog entry properly documents the memory limit increase to address out-of-memory issues.
Consider this minor grammar improvement:
-- OPERA_RTC_S1_BROWSE_LIMITS_MEMORY - Increased to 2Gi to fix out of memory issues. +- OPERA_RTC_S1_BROWSE_LIMITS_MEMORY - Increased to 2Gi to fix out-of-memory issues.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
ENV_CHANGELOG.md(1 hunks)services/harmony/env-defaults(1 hunks)
🧰 Additional context used
🪛 LanguageTool
ENV_CHANGELOG.md
[grammar] ~7-~7: Use a hyphen to join words.
Context: ...ITS_MEMORY - Increased to 2Gi to fix out of memory issues. ## 2025-10-14 ### Cha...
(QB_NEW_EN_HYPHEN)
[grammar] ~7-~7: Use a hyphen to join words.
Context: ..._MEMORY - Increased to 2Gi to fix out of memory issues. ## 2025-10-14 ### Change...
(QB_NEW_EN_HYPHEN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build (22.14.x)
- GitHub Check: compare-services
- GitHub Check: build (22.14.x)
🔇 Additional comments (1)
services/harmony/env-defaults (1)
549-549: LGTM! Memory limit increase appropriately addresses OOM issues.The increase from 512Mi to 2Gi provides necessary headroom to prevent out-of-memory errors. The gap between
REQUESTS_MEMORY(512Mi) andLIMITS_MEMORY(2Gi) is consistent with patterns used by other services in this configuration file and allows Kubernetes to schedule pods efficiently while providing burst capacity.
Jira Issue ID
HARMONY-2186
Description
Updates memory limit for OPERA_RTC_S1_BROWSE to fix out of memory issues.
Local Test Steps
Add the service to LOCALLY_DEPLOYED_SERVICES and verify using
kubectl describethat the pod has a 2Gi memory limitPR Acceptance Checklist
Summary by CodeRabbit
Bug Fixes
Chores
Documentation