Skip to content

HARMONY-2173: Remove inadvertent checkin to obsolete work-reaper project #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025

Conversation

chris-durbin
Copy link
Contributor

@chris-durbin chris-durbin commented Aug 12, 2025

Jira Issue ID

HARMONY-2173

Description

Deployment is failing due to the work-reaper directory existing because of an inadvertent file checked in.

Local Test Steps

Make sure the work-reaper directory does not exist on a fresh clone and then checking out this branch.

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)
  • Harmony in a Box tested (if changes made to microservices or new dependencies added)

Summary by CodeRabbit

  • Chores
    • Removed a deprecated Node CLI option from the workspace npm configuration to align with stable Node releases. This reduces warnings, avoids potential script failures, and improves compatibility across local and CI environments.
    • No user-facing changes or API updates; existing workflows continue to function as before.

Copy link

coderabbitai bot commented Aug 12, 2025

Walkthrough

Removed the node-options=--no-experimental-strip-types setting from services/work-reaper/.npmrc, eliminating that Node CLI option from the workspace’s npm runs.

Changes

Cohort / File(s) Summary
Work Reaper npm config
services/work-reaper/.npmrc
Removed node-options=--no-experimental-strip-types from npmrc

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • indiejames
  • ygliuvt

Poem

I nibbled a flag from the config field,
A tiny leaf from a Node-yielded shield.
Hop, hop—clean paths where options once crept,
Carrot-bright logs where silence is kept.
With one small tweak, my garden is neat—
Fewer sprigs under developer feet. 🥕🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 040f42e and a21bf31.

📒 Files selected for processing (1)
  • services/work-reaper/.npmrc (0 hunks)
💤 Files with no reviewable changes (1)
  • services/work-reaper/.npmrc
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: compare-services
  • GitHub Check: build (22.14.x)
  • GitHub Check: build (22.14.x)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch harmony-2173-2

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@chris-durbin chris-durbin merged commit 7ec39c6 into main Aug 12, 2025
6 checks passed
@chris-durbin chris-durbin deleted the harmony-2173-2 branch August 12, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants