Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snyk config #8

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Add snyk config #8

merged 2 commits into from
Jun 19, 2024

Conversation

owenlittlejohns
Copy link
Member

Description

This PR builds on some work that @flamingbear has done in other repositories to add a .snyk file that will ensure Snyk uses the correct version of Python when building an environment to scan the Swath Projector dependency tree. This will avoid false positives in our Snyk scans.

This change does not impact the service and only relates to our CI/CD (so it doesn't need a release or updated notes in the change log).

Jira Issue ID

N/A

Local Test Steps

Check the scans pass. After merging check the overview of the Snyk project in the UI to ensure the nightly scan picked up the correct Python version.

PR Acceptance Checklist

  • Jira ticket acceptance criteria met.
  • CHANGELOG.md updated to include high level summary of PR changes.
  • docker/service_version.txt updated if publishing a release.
  • Tests added/updated and passing.
  • Documentation updated (if needed).

Copy link
Member

@flamingbear flamingbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@owenlittlejohns owenlittlejohns merged commit 311dacd into main Jun 19, 2024
4 checks passed
@owenlittlejohns owenlittlejohns deleted the add-snyk-config branch June 19, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants