Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Doxygen config #2370

Merged
merged 8 commits into from
Nov 27, 2023
Merged

Update Doxygen config #2370

merged 8 commits into from
Nov 27, 2023

Conversation

thomas-bc
Copy link
Collaborator

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Updates a couple things with regards to Doxygen. I believe no autocoded files were being processed, as build-* directories were being excluded. Fixed by renaming the build cache.

Also removing the \subpage directives as those were going stale and are un-maintainable. Each subpage includes a link to an auto-generated page that list all the classes within, so they weren't needed anyways.

Rationale

Fixes #1989

@thomas-bc thomas-bc requested a review from LeStarch November 15, 2023 03:32
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok. I'd like to see how this looks post-build....a few minor comments.

@@ -38,7 +38,8 @@ PROJECT_NAME = "F´ Flight Software - C/C++ Documentation"
# could be handy for archiving the generated documentation or if some version
# control system is used.

PROJECT_NUMBER = NASA-v1.6.0
# commented out to avoid having to update it every release
# PROJECT_NUMBER = NASA-v1.6.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better way to fill this in?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now using VERSIONED_OUTPUT variable, defaults to devel if not specified.

docs/doxygen/mainpage.md Outdated Show resolved Hide resolved
@LeStarch
Copy link
Collaborator

Do you have a branch where I can see the output?

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The down side of removing those subpage links is that access to the SDD in an ordered fashion disappears.

Yes, you can get to the class documentation, but not easily in the expected flow:

index -> package -> SDD -> c++/class documentation

Can we fix this or discuss?

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively approving, but please consider my one comment before merging.

@thomas-bc thomas-bc merged commit ec1a9b9 into devel Nov 27, 2023
36 checks passed
@thomas-bc thomas-bc deleted the issue-1989 branch November 27, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include *ComponentBase classes in Doxygen documentation
2 participants