Pass Environment To CMake in all Cases #235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| stdout, stderr = cmake_handler._run_cmake( | ||
| arguments=arguments, workdir=test_directory, environment=environment, write_override=True) | ||
| # Read only mode | ||
| arguments = arguments |
Check failure
Code scanning / CodeQL
Redundant assignment Error test
| cmake_refresh_cache(True, cmake_handler) | ||
|
|
||
|
|
||
| def test_refresh_cache_refresh(cmake_handler): |
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning test
|
Closing, incorrect branch and issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
When
settings.inidefines an environment, it needs to ensure that that environment is passed to CMake in all cases (with the exception of thecmake --helptest.Rationale
Fixes nasa/fprime#2033
Testing/Review Recommendations
Added a number of UTs to test key functionality in
cmake.pyFuture Work
Environment should be passed to wrapped utilities too (fpp, etc). This will require more work: nasa/fprime#3081
This extra work is not the cause of the reported issue.