Fix #2650, Correct input buffer size in fs_UT#2683
Open
heathdutton wants to merge 1 commit intonasa:mainfrom
Open
Fix #2650, Correct input buffer size in fs_UT#2683heathdutton wants to merge 1 commit intonasa:mainfrom
heathdutton wants to merge 1 commit intonasa:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
The
Test_CFE_FS_ParseInputFileNameExtest passes anInputBufSizeof10for an empty string literal""which is only 1 byte. Address Sanitizer flags this as a read buffer overflow since the function is told it can read 10 bytes from a 1-byte buffer.Fixes #2650
Testing performed
Code inspection. The empty string causes the function to take the early-out path at the
InputBuffer[0] != 0check, so the expected resultCFE_FS_INVALID_PATHis unchanged regardless of the size value. The fix simply makes the declared size match reality.Expected behavior changes
No behavior change. Test exercises the same code path and expects the same result.
System(s) tested on
N/A -- test-only change, verified by inspection
Additional context
N/A
Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Heath Dutton / Personal