Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

112 implement multi channel redis #125

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Conversation

asgibson
Copy link
Contributor

Multiple channel Redis subscriptions are now allowed.
Example with experimental Redis publisher script included.

@asgibson asgibson added the enhancement New feature or request label Mar 13, 2024
@asgibson asgibson self-assigned this Mar 13, 2024
@asgibson asgibson linked an issue Mar 13, 2024 that may be closed by this pull request
@asgibson asgibson force-pushed the 112-implement-multi-channel-redis branch 2 times, most recently from ef3fc27 to 0891e3c Compare March 15, 2024 17:11
@asgibson asgibson force-pushed the 112-implement-multi-channel-redis branch 2 times, most recently from b0611c5 to 8858c1c Compare March 22, 2024 18:54
Updated CONFIG for use by redis-experiment-publisher
  shows a simple way to see data move through redis to OnAIR
Added custom error to DataSource for key config errors
Fixed columnization of redis_adapter
Redis adapter now checks multiple channels
  detects when time is missing from received message
  helps detect unused keys
  helps detect missing expected keys
  warns if listener exits
Updated and added necessary unit tests for coverage and code verification
Named generic plugins for redis example
Added to README how to run the Redis example
Rebased to main
Copy link
Contributor

@the-other-james the-other-james left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Runs on my machine, and I tested using your excellent instructions/script to launch the redis publisher.

@@ -14,6 +14,110 @@ Create a conda environment with the necessary packages

conda env create -f environment.yml

## Redis example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These instructions are great!

We many want to consider moving them to the wiki in order to keep the README shorter.

@asgibson asgibson merged commit bd1a94e into main Apr 8, 2024
2 checks passed
@asgibson asgibson deleted the 112-implement-multi-channel-redis branch April 8, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement multi-channel Redis
2 participants