test: enhance xfail markers with specific reasons in timestamp_test.py #2065
+56
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-56
to
+58
| request.applymarker(pytest.mark.xfail) | ||
| request.applymarker(pytest.mark.xfail(reason="Second precision not supported")) |
There was a problem hiding this comment.
should we skipping this one, if it isn't and can't be supported?
Comment on lines
+167
to
169
| request.applymarker( | ||
| pytest.mark.xfail(reason="Backend does not support date type") | ||
| ) |
Comment on lines
+103
to
+105
| (any(x in str(constructor) for x in ("pyarrow",)) and is_windows()), | ||
| "PyArrow timezone not supported on Windows", | ||
| ), |
There was a problem hiding this comment.
I've just noticed this check isn't valid:
https://arrow.apache.org/docs/python/install.html#tzdata-on-windows
Or more accurately, these shouldn't xfail on just is_windows().
You'd want something like:
- https://github.com/vega/altair/blob/a196172329fb6d03529bf21a7f58c8bb0f698dd4/tests/__init__.py#L30-L41
- https://github.com/vega/altair/blob/a196172329fb6d03529bf21a7f58c8bb0f698dd4/tests/__init__.py#L104-L140
FAILED tests/selectors_test.py::test_datetime[pandas[pyarrow]]
FAILED tests/selectors_test.py::test_datetime[pyarrow]
FAILED tests/expr_and_series/dt/replace_time_zone_test.py::test_replace_time_zone_none[pyarrow]
FAILED tests/expr_and_series/dt/replace_time_zone_test.py::test_replace_time_zone_none[pandas[pyarrow]]
FAILED tests/expr_and_series/dt/replace_time_zone_test.py::test_replace_time_zone_none_series[pyarrow]
FAILED tests/expr_and_series/dt/replace_time_zone_test.py::test_replace_time_zone_series[pyarrow]
FAILED tests/expr_and_series/dt/replace_time_zone_test.py::test_replace_time_zone[pandas[pyarrow]]
FAILED tests/expr_and_series/dt/replace_time_zone_test.py::test_replace_time_zone_none_series[pandas[pyarrow]]
FAILED tests/expr_and_series/dt/replace_time_zone_test.py::test_replace_time_zone[pyarrow]
FAILED tests/expr_and_series/dt/replace_time_zone_test.py::test_replace_time_zone_series[pandas[pyarrow]]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pyarrow-us-ns-expected3]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pandas[pyarrow]-us-ns-expected3]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pandas[pyarrow]-us-ms-expected5]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pandas[pyarrow]-ms-ns-expected6]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pandas[pyarrow]-ns-us-expected1]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pandas[pyarrow]-ms-us-expected7]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pyarrow-ns-ms-expected2]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pandas[pyarrow]-ms-ms-expected8]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pyarrow-ms-ms-expected8]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pyarrow-us-ms-expected5]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pyarrow-ms-ns-expected6]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pandas[pyarrow]-s-ns-expected9]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pyarrow-ns-ns-expected0]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pandas[pyarrow]-us-us-expected4]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pandas[pyarrow]-s-us-expected10]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pyarrow-us-us-expected4]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pandas[pyarrow]-ns-ms-expected2]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pyarrow-ns-us-expected1]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pandas[pyarrow]-s-ms-expected11]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pyarrow-s-ms-expected11]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pyarrow-s-ns-expected9]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pyarrow-ms-us-expected7]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pyarrow-s-us-expected10]
FAILED tests/expr_and_series/dt/timestamp_test.py::test_timestamp_datetimes_tz_aware[pandas[pyarrow]-ns-ns-expected0]
FAILED tests/expr_and_series/dt/convert_time_zone_test.py::test_convert_time_zone[pandas[pyarrow]]
FAILED tests/expr_and_series/dt/convert_time_zone_test.py::test_convert_time_zone_series[pandas[pyarrow]]
FAILED tests/expr_and_series/dt/convert_time_zone_test.py::test_convert_time_zone_from_none[pyarrow]
FAILED tests/expr_and_series/dt/convert_time_zone_test.py::test_convert_time_zone_from_none[pandas[pyarrow]]
FAILED tests/expr_and_series/dt/convert_time_zone_test.py::test_convert_time_zone_series[pyarrow]
FAILED tests/expr_and_series/dt/convert_time_zone_test.py::test_convert_time_zone[pyarrow]
FAILED tests/frame/to_numpy_test.py::test_to_numpy_tz_aware[pandas[pyarrow]]
FAILED tests/frame/to_numpy_test.py::test_to_numpy_tz_aware[pyarrow]
FAILED tests/series_only/to_numpy_test.py::test_to_numpy_tz_aware[pandas[pyarrow]]
FAILED tests/series_only/to_numpy_test.py::test_to_numpy_tz_aware[pyarrow]
FAILED tests/expr_and_series/cast_test.py::test_cast_datetime_tz_aware[pyarrow]There was a problem hiding this comment.
I needed to install it to investigate #2042 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below