This repository has been archived by the owner on Mar 1, 2023. It is now read-only.
Issue 490 #513
Merged
Issue 490 #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
prisis
commented
Apr 10, 2017
prisis
commented
| Q | A |
|---|---|
| Branch? | develop |
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | no |
| Fixed tickets | #490 |
| License | MIT |
Nitpick-CI
reviewed
Apr 10, 2017
| */ | ||
| protected $webprofiler; | ||
| protected $Profiler |
There was a problem hiding this comment.
There must not be more than one property declared per statement
Codecov Report
@@ Coverage Diff @@
## develop #513 +/- ##
=============================================
- Coverage 88.19% 85.63% -2.56%
- Complexity 5036 5151 +115
=============================================
Files 399 403 +4
Lines 12586 12850 +264
=============================================
- Hits 11100 11004 -96
- Misses 1486 1846 +360
Continue to review full report at Codecov.
|
# Conflicts: # src/Viserio/Bridge/Twig/Providers/TwigBridgeDataCollectorsServiceProvider.php # src/Viserio/Component/Foundation/Application.php # src/Viserio/Component/Foundation/Bootstrap/LoadConfiguration.php # src/Viserio/Component/Foundation/Bootstrap/LoadServiceProvider.php # src/Viserio/Component/Foundation/Bootstrap/RegisterStaticalProxys.php # src/Viserio/Component/Foundation/Bootstrap/SetRequestForConsole.php # src/Viserio/Component/Foundation/Console/Commands/KeyGenerateCommand.php # src/Viserio/Component/Foundation/DataCollectors/NarrowsparkDataCollector.php # src/Viserio/Component/Foundation/Http/Kernel.php # src/Viserio/Component/Foundation/Providers/ConfigureLoggingServiceProvider.php # src/Viserio/Component/Foundation/Tests/DataCollectors/NarrowsparkDataCollectorTest.php # src/Viserio/Component/Foundation/Tests/Http/KernelTest.php # src/Viserio/Component/Foundation/Tests/Providers/ConfigureLoggingServiceProviderTest.php # src/Viserio/Component/Parsers/Providers/ParsersServiceProvider.php # src/Viserio/Component/View/Engines/MarkdownEngine.php # src/Viserio/Component/WebProfiler/Providers/WebProfilerSwiftMailerBridgeServiceProvider.php
Nitpick-CI
reviewed
Apr 23, 2017
| * | ||
| * @return \Psr\Http\Message\ResponseInterface | ||
| */ | ||
| public function getResponse($value='') |
There was a problem hiding this comment.
- Incorrect spacing between argument
$valueand equals sign; expected 1 but found 0 - Incorrect spacing between default value and equals sign for argument
$value; expected 1 but found 0
Nitpick-CI
reviewed
Apr 23, 2017
| * | ||
| * @return \Psr\Http\Message\ResponseInterface | ||
| */ | ||
| public function getResponse($value='') |
There was a problem hiding this comment.
- Incorrect spacing between argument
$valueand equals sign; expected 1 but found 0 - Incorrect spacing between default value and equals sign for argument
$value; expected 1 but found 0
modified: src/Viserio/Component/Session/Store.php modified: src/Viserio/Component/Session/Tests/StoreTest.php
modified: src/Viserio/Component/Session/Tests/Middleware/VerifyCsrfTokenMiddlewareTest.php modified: src/Viserio/Component/Session/Tests/SessionManagerTest.php
modified: src/Viserio/Component/Session/SessionManager.php modified: src/Viserio/Component/Session/Tests/Middleware/StartSessionMiddlewareTest.php
modified: src/Viserio/Component/Session/Handler/CookieSessionHandler.php modified: src/Viserio/Component/Session/Middleware/VerifyCsrfTokenMiddleware.php modified: src/Viserio/Component/Session/Tests/Handler/CookieSessionHandlerTest.php modified: src/Viserio/Component/Support/Http/ClientIp.php
modified: src/Viserio/Component/Session/Middleware/StartSessionMiddleware.php modified: src/Viserio/Component/Session/Middleware/VerifyCsrfTokenMiddleware.php
some sessions changes Apply fixes from StyleCI fix first tests fix cookie handling working on session (#540) Refactor some old session code check if session is open and use http_only with true as default modified: src/Viserio/Component/Session/Middleware/StartSessionMiddleware.php modified: src/Viserio/Component/Session/Middleware/VerifyCsrfTokenMiddleware.php
Nitpick-CI
reviewed
May 20, 2017
| @@ -16,26 +17,31 @@ class CacheServiceProvider implements ServiceProvider | |||
| public function getServices() | |||
| { | |||
| return [ | |||
| CacheManagerContract::class => [self::class, 'registerCacheFactory'], | |||
| CacheManager::class => function (ContainerInterface $container) { | |||
| CacheManagerContract::class => function (ContainerInterface $container): CacheManagerContract { | |||
There was a problem hiding this comment.
Expected 1 space after closing parenthesis; found 0
Nitpick-CI
reviewed
May 20, 2017
| CacheManagerContract::class => function (ContainerInterface $container): CacheManagerContract { | ||
| return new CacheManager($container); | ||
| }, | ||
| CacheManager::class => function (ContainerInterface $container): CacheManagerContract { |
There was a problem hiding this comment.
Expected 1 space after closing parenthesis; found 0
Nitpick-CI
reviewed
May 20, 2017
| return $container->get(CacheManagerContract::class); | ||
| }, | ||
| 'cache' => function (ContainerInterface $container) { | ||
| 'cache' => function (ContainerInterface $container): CacheManagerContract { |
There was a problem hiding this comment.
Expected 1 space after closing parenthesis; found 0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.