Skip to content

fix(tests): address CodeQL findings - skip incomplete test #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mischadiehm merged 2 commits into from
Dec 26, 2025
Merged

fix(tests): address CodeQL findings - skip incomplete test #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac7dc80
fix(tests): address CodeQL findings - skip incomplete test
mischadiehm Dec 26, 2025
f3d7e08
fix(introspection): add missing vendor_specific field to VendorSequen…
mischadiehm Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/network_toolkit/common/table_providers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,7 @@ class VendorSequenceInfoTableProvider(BaseModel, BaseTableProvider):
vendor_names: list[str]
verbose: bool = False
config: NetworkConfig | None = None
vendor_specific: bool = False

def get_table_definition(self) -> TableDefinition:
title_suffix = ""
Expand Down
9 changes: 3 additions & 6 deletions tests/test_backup_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ def temp_backup_dir(self, tmp_path: Path) -> Path:
backup_dir.mkdir()
return backup_dir

@pytest.mark.skip(reason="Requires full command flow mocking - see issue #42")
def test_backup_command_creates_timestamped_directory(
self, temp_backup_dir: Path
) -> None:
Expand All @@ -293,14 +294,10 @@ def test_backup_command_creates_timestamped_directory(
# Mock pattern: device_YYYYMMDD_HHMMSS

# After running backup, check directory exists
list(temp_backup_dir.glob("test-device_*"))
backup_dirs = list(temp_backup_dir.glob("test-device_*"))

# This assertion would verify directory was created
# assert len(backup_dirs) == 1
# assert re.match(expected_pattern, backup_dirs[0].name)

# Note: Full implementation requires mocking the entire command flow
pass
assert len(backup_dirs) == 1

def test_backup_saves_text_outputs_to_files(self, temp_backup_dir: Path) -> None:
"""Verify text outputs from BackupResult are saved as files."""
Expand Down
Loading