Support directories to scan on the command line #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prantlf
force-pushed
the
lint-dirs
branch
2 times, most recently
from
e6c28f5
to
9fc221b
Compare
Allow limiting the scan to selected directories. If no directory is provided, the current directory will be scanned, as it was. BREAKING CHANGE: If you passed a single directory to denolint to specify the project root, it will not work any more. You can pass the root directory using the argument -r,--root. However, it was used only if neither .denolintignore nor .eslintignore were found and was passed instead of either of them to the walker. Because the root directory was no file path, I think that it was useless. Nevertheless, I implemented the previous functionality using the argument -r,--root, which might be worth for other purposes later.
prantlf
added a commit
to prantlf/denolint
that referenced
this pull request
Sep 28, 2022
This is the first version released after forking the [customisation] of the [original project]. * Scan specific directories ([631], [647]) * Scan directories configured by `files.include` ([635], [645]) * Fix handling of the configuration `files.exclude` ([635], [646]) * Support disabling rules in souces using `eslint-disable` ([630], [642]) * Support including and excluding rules in the `lint` method ([631], [643]) * Execute the command-line tool `denolint` without loading the Node.js VM ([648]) * Allow specifying directories, files and patterns as input for checking [customisation]: https://github.com/prantlf/node-rs/commits/combined [original project]: https://github.com/napi-rs/node-rs/tree/main/packages/deno-lint [630]: napi-rs/node-rs#630 [631]: napi-rs/node-rs#631 [635]: napi-rs/node-rs#635 [642]: napi-rs/node-rs#642 [643]: napi-rs/node-rs#643 [645]: napi-rs/node-rs#645 [646]: napi-rs/node-rs#646 [647]: napi-rs/node-rs#647 [648]: napi-rs/node-rs#648
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow limiting the scan to selected directories. If no directory is provided, the current directory will be scanned, as it was.
BREAKING CHANGE: If you passed a single directory to
denolintto specify the project root, it will not work any more. You can pass the root directory using the argument-r,--root. However, it was used only if neither.denolintignorenor.eslintignorewere found and was passed instead of either of them to the walker. Because the root directory was no file path, I think that it was useless. Nevertheless, I implemented the previous functionality using the argument-r,--root, which might be worth for other purposes later.Attempts to fix #635.