Support files.include from .denolint.json #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prantlf
force-pushed
the
files-include
branch
from
7a3e923
to
fbd9a99
Compare
Complete the existing support of files.exclude. Once files.include is provided, the current directory will not be added to the source directories by default. BREAKING CHANGE: If you used files.include in your .denolint.json to list a subset of the subdirectories, but you expected denolint to search all subdirectories in the current directory, this will not happen any more. If you use a config file with files.include, only directories listed by files.include will be searched.
prantlf
force-pushed
the
files-include
branch
from
fbd9a99
to
9c017db
Compare
prantlf
added a commit
to prantlf/denolint
that referenced
this pull request
Sep 28, 2022
This is the first version released after forking the [customisation] of the [original project]. * Scan specific directories ([631], [647]) * Scan directories configured by `files.include` ([635], [645]) * Fix handling of the configuration `files.exclude` ([635], [646]) * Support disabling rules in souces using `eslint-disable` ([630], [642]) * Support including and excluding rules in the `lint` method ([631], [643]) * Execute the command-line tool `denolint` without loading the Node.js VM ([648]) * Allow specifying directories, files and patterns as input for checking [customisation]: https://github.com/prantlf/node-rs/commits/combined [original project]: https://github.com/napi-rs/node-rs/tree/main/packages/deno-lint [630]: napi-rs/node-rs#630 [631]: napi-rs/node-rs#631 [635]: napi-rs/node-rs#635 [642]: napi-rs/node-rs#642 [643]: napi-rs/node-rs#643 [645]: napi-rs/node-rs#645 [646]: napi-rs/node-rs#646 [647]: napi-rs/node-rs#647 [648]: napi-rs/node-rs#648
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete the existing support of
files.exclude.Once
files.includeis provided, the current directory will not be added to the source directories by default.BREAKING CHANGE: If you used
files.includein your.denolint.jsonto list a subset of the subdirectories, but you expecteddenolintto search all subdirectories in the current directory, this will not happen any more. If you use a config file withfiles.include, only directories listed by files.include will be searched.Attempts to fix #635.