Support list of rules to exclude and include in lint and webpack #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While enableAllRules serves as "tags": ["recommended"], there is no way to specify "exclude": [] as known from .denolint.json. Adding excludeRules is not exactly according to the config schema, but it is the simplest change without breaking the current option schema.
prantlf
force-pushed
the
exclude-rules
branch
from
e0a9812
to
af09e57
Compare
prantlf
changed the title
Complement the previous commit adding support for rules.exclude. While enableAllRules serves as "tags": ["recommended"], there is no way to specify "include": [] as known from .denolint.json.
prantlf
force-pushed
the
exclude-rules
branch
from
87db9b7
to
2e9d121
Compare
prantlf
added a commit
to prantlf/denolint
that referenced
this pull request
Sep 28, 2022
This is the first version released after forking the [customisation] of the [original project]. * Scan specific directories ([631], [647]) * Scan directories configured by `files.include` ([635], [645]) * Fix handling of the configuration `files.exclude` ([635], [646]) * Support disabling rules in souces using `eslint-disable` ([630], [642]) * Support including and excluding rules in the `lint` method ([631], [643]) * Execute the command-line tool `denolint` without loading the Node.js VM ([648]) * Allow specifying directories, files and patterns as input for checking [customisation]: https://github.com/prantlf/node-rs/commits/combined [original project]: https://github.com/napi-rs/node-rs/tree/main/packages/deno-lint [630]: napi-rs/node-rs#630 [631]: napi-rs/node-rs#631 [635]: napi-rs/node-rs#635 [642]: napi-rs/node-rs#642 [643]: napi-rs/node-rs#643 [645]: napi-rs/node-rs#645 [646]: napi-rs/node-rs#646 [647]: napi-rs/node-rs#647 [648]: napi-rs/node-rs#648
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
enableAllRulesserves as"tags": ["recommended"], there is no way to specify"exclude": [...]and"include": [...]as known from.denolint.json. Adding argumentsexcludeRulesandincludeRulesis not exactly according to the config schema, butenableAllRulesis not either. And it is the simplest change without breaking the current arguments.Attempts to help implementing IDE plugins using
denolint, as mentioned in a comment at #631.Another way could be expecting
RulesConfigas anEitherwith thebool. It would need implementing serialisation ofRulesConfig.