Update instruction how to update contraints files #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
cnstt
suggested changes
Apr 14, 2025
|
|
||
| ```bash | ||
| uv pip compile --python-version 3.11 --upgrade --output-file resources/constraints/constraints_py3.11_docs.txt pyproject.toml resources/constraints/version_denylist.txt resources/constraints/version_denylist_examples.txt ../docs/requirements.txt resources/constraints/pydantic_le_2.txt --extra pyqt5 --extra pyqt6 --extra pyside2 --extra pyside6_experimental --extra testing --extra testing_extra --extra optional |
There was a problem hiding this comment.
Shouldn't resources/constraints/version_denylist_examples.txt be kept (as in napari/napari#7788 ) ?
There was a problem hiding this comment.
I have changed from docs to normal constraints, as docs are still on python 3.10.
Once we understand the source of problems in #7714 we may get docs constraints here.
| @@ -118,10 +118,12 @@ These constraints files need to be updated at least weekly on Monday, and may al | |||
| To get updated constraints for a PR, use `@napari-bot update constraints` in a PR comment, then follow the instruction added by the bot to the conversation. | |||
|
|
|||
| ````{admonition} Example | |||
| To update the docs constraints file, assuming you have the `napari/napari` repo and `napari/docs` repo cloned next to each other, you can install [uv](https://astral.sh/blog/uv) and run the following command from the root of the `napari` repo: | |||
| To manually update the constraint files, you need to have the [`uv`](https://github.com/astral-sh/uv) and copy | |||
There was a problem hiding this comment.
Suggested change
| To manually update the constraint files, you need to have the [`uv`](https://github.com/astral-sh/uv) and copy | |
| To manually update the constraints files, you need to have the [`uv`](https://github.com/astral-sh/uv) tool installed, then copy |
| @@ -118,10 +118,12 @@ These constraints files need to be updated at least weekly on Monday, and may al | |||
| To get updated constraints for a PR, use `@napari-bot update constraints` in a PR comment, then follow the instruction added by the bot to the conversation. | |||
|
|
|||
| ````{admonition} Example | |||
| To update the docs constraints file, assuming you have the `napari/napari` repo and `napari/docs` repo cloned next to each other, you can install [uv](https://astral.sh/blog/uv) and run the following command from the root of the `napari` repo: | |||
| To manually update the constraint files, you need to have the [`uv`](https://github.com/astral-sh/uv) and copy | |||
| the command from the second line of a given constraints file. | |||
There was a problem hiding this comment.
Suggested change
| the command from the second line of a given constraints file. | |
| and run the command from the second line of a given constraints file. |
TimMonko
approved these changes
Apr 14, 2025
TimMonko
reviewed
Apr 14, 2025
|
|
||
| ```bash | ||
| uv pip compile --python-version 3.11 --upgrade --output-file resources/constraints/constraints_py3.11_docs.txt pyproject.toml resources/constraints/version_denylist.txt resources/constraints/version_denylist_examples.txt ../docs/requirements.txt resources/constraints/pydantic_le_2.txt --extra pyqt5 --extra pyqt6 --extra pyside2 --extra pyside6_experimental --extra testing --extra testing_extra --extra optional | ||
| uv pip compile --python-version 3.12 --output-file resources/constraints/constraints_py3.12.txt pyproject.toml resources/constraints/version_denylist.txt --extra pyqt6 --extra pyside2 --extra pyside6_experimental --extra testing --extra testing_extra --extra optional |
There was a problem hiding this comment.
this updates 3.12, we want to update docs though, right? I think this does that
Suggested change
| uv pip compile --python-version 3.12 --output-file resources/constraints/constraints_py3.12.txt pyproject.toml resources/constraints/version_denylist.txt --extra pyqt6 --extra pyside2 --extra pyside6_experimental --extra testing --extra testing_extra --extra optional | |
| uv pip compile --python-version 3.10 --output-file resources/constraints/constraints_py3.10_docs.txt pyproject.toml resources/constraints/version_denylist.txt --extra pyqt6 --extra pyside2 --extra pyside6_experimental --extra testing --extra testing_extra --extra optional |
|
@napari-bot make slimgallery |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
closes #670
napari/napari#7642
napari/napari#7487
Description
After the most recent updates of constraints update, we could simplify this instrucition.