Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dockerfiles #2825

Merged

Conversation

networkfusion
Copy link
Member

@networkfusion networkfusion commented Nov 8, 2023

Description

  • Improve layout of commands.
  • Improve comments.
  • Use latest hex2dfu rather than tagged version.
  • Fix location of GCC.
  • Use python:3.10 container for ESP32 and All builds (rather than ppa repo).
  • Add smoke test workflow.
  • Use lwIP GH mirror for NXP (fixes TLS issues).
  • Use ArduPilot GH mirror by default for ChibiOS src (git SVN is too slow and tempremental).
  • Bump dockerfile versions.
  • Use ARG for toolchain component versions (so they are only used in one place).

Motivation and Context

  • Improve maintainability.
  • Ensure Dockerfiles are valid and working before publishing (runs check on PR only).

How Has This Been Tested?

New (smoketest) workflow.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

Superficial changes.
@networkfusion
Copy link
Member Author

networkfusion commented Nov 8, 2023

NOTE: I would like to question whether ENV ESP_PATCH_VER=esp-2021r2-patch5-8.4.0 is still correct?!

AND: whether the hack for Python 3.10 is still required (or use python:3.10 as the docker image as an alternative).

@josesimoes
Copy link
Member

NOTE: I would like to question whether ENV ESP_PATCH_VER=esp-2021r2-patch5-8.4.0 is still correct?!

Yes. That's the latest version in the IDF version we're using.

AND: whether the hack for Python 3.10 is still required (or use python:3.10 as the docker image as an alternative).
Not sure which hack you are referring to, but 3.10 it's the last usable version this IDF allows. Above that, things get totally messed up because of the dependencies they have which are waaaay old and some even deprecated or with security flaws.

@Ellerbach
Copy link
Member

AND: whether the hack for Python 3.10 is still required

That I really don't remember why...

Include TI target as last container.
Comment out TI as known broken
Use python:3.10 container
Improve for all containers and platforms.
@networkfusion
Copy link
Member Author

networkfusion commented Nov 11, 2023

@Ellerbach @josesimoes I hope that this PR is acceptable. It is a little wider in range than I hoped and given issues I had recently (as shown by the workflow runs), decided it was time to add a smoke test.

It will help before #2816 is merged, as it adds multiple improvements to ensure builds and tests against them.

(TI currently commented out as broken (and known see https://discord.com/channels/478725473862549535/1173310502202511450)).

@networkfusion
Copy link
Member Author

Linked to #2832

Should be kept seperate.
@networkfusion networkfusion merged commit a55a007 into nanoframework:main Nov 18, 2023
8 of 14 checks passed
@networkfusion networkfusion deleted the devcontainer-superficial branch December 27, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants