Add Content file deployment to internal storage #814

Ellerbach · 2024-03-13T15:23:35Z

Description

Add Content file deployment to internal storage

** A new version of Debug lib needs to be published first **

Motivation and Context

Add Content file deployment to internal storage
Any "Content" marked as not "Never" will be deployed to the internal storage
Following Add Storage Operation Commands nf-debugger#374.
Addresses Add support for CopyToOutputDirectory in project files Home#1452

How Has This Been Tested?

With test extension

Screenshots

Types of changes

Improvement (non-breaking change that improves a feature, code or algorithm)
Bug fix (non-breaking change which fixes an issue with code or algorithm)
New feature (non-breaking change which adds functionality to code)
Breaking change (fix or feature that would cause existing functionality to change)
Config and build (change in the configuration and build system, has no impact on code or features)
Dependencies (update dependencies and changes associated, has no impact on code or features)
Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

My code follows the code style of this project (only if there are changes in source code).
My changes require an update to the documentation (there are changes that require the docs website to be updated).
I have updated the documentation accordingly (the changes require an update on the docs in this repo).
I have read the CONTRIBUTING document.
I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
I have added new tests to cover my changes.

[version update]

***NO_CI***

networkfusion · 2024-03-13T18:33:30Z

vs-extension.shared/DeployProvider/DeployProvider.cs

+                    if (contents.Any())
+                    {
+                        MessageCentre.InternalErrorWriteLine("Deploying content files to internal storage");
+                        foreach(var file in  contents)


Suggested change

foreach(var file in contents)

foreach(var file in contents)

networkfusion · 2024-03-13T18:41:29Z

vs-extension.shared/DeployProvider/DeployProvider.cs

+                            MessageCentre.InternalErrorWriteLine($"Deploying {file.EvaluatedInclude}");
+                            if(file.EvaluatedInclude.Contains(Path.DirectorySeparatorChar))
+                            {
+                                MessageCentre.InternalErrorWriteLine("File should not be a path, internal storage does not support folders. It will still try to deploy.");


Suggested change

MessageCentre.InternalErrorWriteLine("File should not be a path, internal storage does not support folders. It will still try to deploy.");

MessageCentre.InternalErrorWriteLine("File is included as a path, but internal storage does not support folders. Note: It will still try to deploy.");

Suggested change is trying to convey the error rather than how to handle it (as convention), but if possible, an extra "suggestion" of how to handle the error would be advantagous.

Suggested change is trying to convey the error rather than how to handle it (as convention), but if possible, an extra "suggestion" of how to handle the error would be advantagous.

Yes, I was even thinking to replace the '' by a dash and write it. And also mention that in the docs. I'm open for any improvement on that side. Note that you can also have a look at the 2 other PR, the nf-interpreter one and the nf-debugger one where the core code is located.

Actually, this depends on what are the target capabilities. For ORGPAL boards (and others that offer options other than internal storage) these can be stored in SDCard or USB MSD, for example.
I would suggest a warning message with a generic warning about that being a path and the target device may not support that. Or similar.

ok, so we need an additional setting on the nfproj file to specify which drive to use. By default, in this draft implementation, it's using the internal storage.
Now: what is the interest of being able to deploy on a SDCard or external storage when it's much easier to do it another way?

Considering that this is target related, I would argue that this should go into user prefs and not project.
Apart from that, as this is the 1st pass, its more than OK to default to internal storage.

To your last question: that's, again, hardware dependent. The device may not have internal storage but may have an SDCard. That should be a perfectly valid storage for files being served to HTTP server or used as resources in any application...

How about File is included as a path, but operation does not allow this. Note: It will still try to deploy.

…/nf-Visual-Studio-extension into add-storage-option

…dio-extension into add-storage-option

coderabbitai · 2024-12-02T14:44:09Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Ellerbach · 2024-12-03T12:58:11Z

Closing this PR to reopen a new one. This PR contains tests to add a custom property. This cannot be achieved like this. Further PR to come to fix this.

josesimoes and others added 5 commits October 16, 2018 15:31

Merge pull request #311 from nanoframework/release-1.0.0

3000c13

Update versions for v1.0.0.0 [skip ci]

530f7e6

[version update]

Update CHANGELOG for v1.0.0.0

5e4462b

Update CHANGELOG.md

6ed56c7

Fix contributing link (#764)

b072e9c

***NO_CI***

nfbot added the Type: enhancement label Mar 13, 2024

Ellerbach requested a review from josesimoes March 13, 2024 15:24

networkfusion reviewed Mar 13, 2024

View reviewed changes

josesimoes added Status: in progress ⚠️ DO NOT MERGE ⚠️ VS2019 Specific to VS2019 VS2022 Specific to VS2022 labels Mar 20, 2024

josesimoes force-pushed the add-storage-option branch from ee690a8 to f9880ed Compare March 21, 2024 02:56

Ellerbach and others added 3 commits March 21, 2024 13:02

Adding file operation deployment

5be5f83

adjusting code

31a6721

Update debugger sub-module @4a1ea12

a9319e2

josesimoes force-pushed the add-storage-option branch from f9880ed to a9319e2 Compare March 21, 2024 13:03

Ellerbach added 4 commits March 22, 2024 18:37

adjusting for deployment

351c4a6

Adding file operation deployment

9acf684

adjusting code

5938e0b

adjusting for deployment

486f70b

josesimoes force-pushed the add-storage-option branch from 351c4a6 to 486f70b Compare April 1, 2024 10:47

Ellerbach and others added 4 commits July 16, 2024 11:00

making additional tests

ffd76ac

Merge branch 'add-storage-option' of https://github.com/nanoframework…

ebca4d1

…/nf-Visual-Studio-extension into add-storage-option

Merge branch 'main' of https://github.com/nanoframework/nf-Visual-Stu…

05e97ed

…dio-extension into add-storage-option

commit before clising with some work in progress

925ae35

Ellerbach closed this Dec 3, 2024

nfbot added invalid and removed Type: enhancement Status: in progress ⚠️ DO NOT MERGE ⚠️ VS2019 Specific to VS2019 VS2022 Specific to VS2022 labels Dec 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Content file deployment to internal storage #814

Add Content file deployment to internal storage #814

Ellerbach commented Mar 13, 2024 •

edited by josesimoes

Loading

networkfusion Mar 13, 2024

networkfusion Mar 13, 2024

networkfusion Mar 13, 2024

Ellerbach Mar 15, 2024

josesimoes Mar 18, 2024

Ellerbach Mar 18, 2024

josesimoes Mar 19, 2024

josesimoes Mar 19, 2024

networkfusion Mar 21, 2024

coderabbitai bot commented Dec 2, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Ellerbach commented Dec 3, 2024

	MessageCentre.InternalErrorWriteLine("File should not be a path, internal storage does not support folders. It will still try to deploy.");
	MessageCentre.InternalErrorWriteLine("File is included as a path, but internal storage does not support folders. Note: It will still try to deploy.");

Add Content file deployment to internal storage #814

Add Content file deployment to internal storage #814

Conversation

Ellerbach commented Mar 13, 2024 • edited by josesimoes Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coderabbitai bot commented Dec 2, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Ellerbach commented Dec 3, 2024

Ellerbach commented Mar 13, 2024 •

edited by josesimoes

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)