Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in CorDebugType and CorDebugClass #300

Merged

Conversation

josesimoes
Copy link
Member

Description

Motivation and Context

  • Despite the existing code was working fine. No issues whatsoever with peeking static's (value was visible in watch, immediate, mouse over, etc.) it's always nice to improve code.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@nfbot
Copy link
Member

nfbot commented Sep 21, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes force-pushed the fix-for-static-variable-examination branch from e1fc349 to 9dd44c0 Compare September 21, 2018 10:39
- Add proper implementation for GetStaticFieldValue and GetParameterizedType
(from NETMF/netmf-interpreter#552)
- Tidy code

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes force-pushed the fix-for-static-variable-examination branch from 9dd44c0 to 1f2e5b2 Compare September 21, 2018 12:07
@josesimoes josesimoes merged commit 8f6454b into nanoframework:develop Sep 21, 2018
@josesimoes josesimoes deleted the fix-for-static-variable-examination branch September 21, 2018 12:19
snikeguo pushed a commit to snikeguo/nf-Visual-Studio-extension that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants