Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding hardware test #351
base: main
Are you sure you want to change the base?
Adding hardware test #351
Changes from 22 commits
b605096
20ed2bc
d0c1ab2
00f9e1d
679e46b
bd361a0
5af0ba5
a982d02
1962af4
b9ab875
2aa239a
9041b38
7e7818d
727367b
c97f0ab
3342e62
9236f0e
bf05b05
6c5ce4e
60c22e9
7595bb9
06a9889
a43ad17
23e0e89
1958f63
d439b3a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve parameter configuration and validation.
The default value of
none
forappComponents
could lead to scenarios where no tests are executed, which aligns with the reported issue in PR comments about catching missing tests.Consider these improvements:
Here's a suggested improvement:
🧰 Tools
🪛 yamllint
[warning] 34-34: wrong indentation: expected 2 but found 0
(indentation)