fix: (WIP) Improve graph pointer interaction #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to begin improving pointer interaction with the graph and nodes by no longer checking the global pointer location, and instead using purely responses from both the graph and nodes. Currently there's still some strange behaviour with the node dragging where they occasionally jump around after completing a drag. Button widgets also appear to drag the node. May want to separately land some of the pointer cleanup and node UI interaction (e.g. try to propagate clicks from content UI through frame to the outer-most UI?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP attempt to begin improving pointer interaction with the graph and nodes by no longer checking the global pointer location, and instead using purely responses from both the graph and nodes. This aims to fix the issue where a floating window above the graph should block user interaction with the graph, but doesn't.
Currently there's still some strange behaviour with the node dragging where they occasionally jump around after completing a drag. Button widgets also appear to drag the node.
May want to separately land some of the pointer cleanup and node UI interaction (e.g. try to propagate clicks from content UI through frame to the outer-most UI?).