Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make to_param behave as in default AR models #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mattvanhorn
Copy link

This makes obfuscate_id behave like the default ActiveRecord models, where unsaved models return nil on calls to to_param

@mattvanhorn
Copy link
Author

not sure what this test error is, or how it is caused. :(

gilesbowkett added a commit to team-eden/obfuscate_id that referenced this pull request Feb 15, 2018
https://github.com/namick/obfuscate_id/pull/56/files

Merge remote-tracking branch 'mattvanhorn/fix-unsaved-behavior'
@gilesbowkett
Copy link

fyi, merged into my fork, specs pass there @mattvanhorn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants