Fix tox factor name to actually run tests. #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis build failed due to inaccessible RabbitMQ management API. |
|
😳 Thanks for fixing this! Looks like we're now being bitten by https://travis-ci.community/t/is-rabbitmq-service-down/4362/2 Adding |
This should fix inaccessible RabbitMQ API.
|
Thanks Matt, I got the tests to run. Well, not on Python 3.4 as PyYAML doesn't support that version anymore. In other cases the tests run, but I'd argue that getting them to pass should happen in another issue/PR. |
|
Closing thiis as Travis CI isn't relevant anymore. Will try to port CI for nameko-sentry to Github Actions in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to start work on #24, I've noticed that all tox envs are green but... tox doesn't actually run the tests. This PR fixes factor name in tox.ini so that the proper commands are executed.