Add "lazy" connection option #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameko_grpc/client.py
Outdated
| ): | ||
| self.target = target | ||
| self.stub = stub | ||
| self.compression_algorithm = compression_algorithm | ||
| self.compression_level = compression_level # NOTE not used | ||
| self.ssl = SslConfig(ssl) | ||
| self.lazy = lazy |
There was a problem hiding this comment.
This could be lazy_startup or something more intentational than just lazy
| self._channel = self._get_channel() | ||
|
|
||
| def _get_channel(self): | ||
| with self._channel_creation_lock: |
There was a problem hiding this comment.
This is in wrong place, or there should be another self._channel is None check after the lock. Other threads at the moment would wait but still create additional channels.
There was a problem hiding this comment.
You're right.
I think it should be fixed now
stephenc-pace
approved these changes
Oct 2, 2023
timbu
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a "lazy" option to the client/dependency provider, defaulting to
False. This option means we only try to connect when a call is made rather than on startup.This avoids cases where a dependent service won't start unless its dependency service is already running. Otherwise cascading failures might be a problem.