Fixed a coding mistake:

if(typeof something !== undefined) --> if(typeof something !== 'undefined')
nakupanda · Jun 11, 2014 · d364b82 · d364b82
1 parent 8714639
commit d364b82
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 15 deletions.
diff --git a/dist/js/bootstrap-dialog.js b/dist/js/bootstrap-dialog.js
@@ -468,24 +468,24 @@
             $button.prop('id', button.id);
 
             // Icon
-            if (typeof button.icon !== undefined && $.trim(button.icon) !== '') {
+            if (typeof button.icon !== 'undefined' && $.trim(button.icon) !== '') {
                 $button.append(this.createButtonIcon(button.icon));
             }
 
             // Label
-            if (typeof button.label !== undefined) {
+            if (typeof button.label !== 'undefined') {
                 $button.append(button.label);
             }
 
             // Css class
-            if (typeof button.cssClass !== undefined && $.trim(button.cssClass) !== '') {
+            if (typeof button.cssClass !== 'undefined' && $.trim(button.cssClass) !== '') {
                 $button.addClass(button.cssClass);
             } else {
                 $button.addClass('btn-default');
             }
 
             // Hotkey
-            if (typeof button.hotkey !== undefined) {
+            if (typeof button.hotkey !== 'undefined') {
                 this.registeredButtonHotkeys[button.hotkey] = $button;
             }
 

diff --git a/dist/js/bootstrap-dialog.min.js b/dist/js/bootstrap-dialog.min.js
diff --git a/examples/assets/bootstrap-dialog/js/bootstrap-dialog.js b/examples/assets/bootstrap-dialog/js/bootstrap-dialog.js
@@ -468,24 +468,24 @@
             $button.prop('id', button.id);
 
             // Icon
-            if (typeof button.icon !== undefined && $.trim(button.icon) !== '') {
+            if (typeof button.icon !== 'undefined' && $.trim(button.icon) !== '') {
                 $button.append(this.createButtonIcon(button.icon));
             }
 
             // Label
-            if (typeof button.label !== undefined) {
+            if (typeof button.label !== 'undefined') {
                 $button.append(button.label);
             }
 
             // Css class
-            if (typeof button.cssClass !== undefined && $.trim(button.cssClass) !== '') {
+            if (typeof button.cssClass !== 'undefined' && $.trim(button.cssClass) !== '') {
                 $button.addClass(button.cssClass);
             } else {
                 $button.addClass('btn-default');
             }
 
             // Hotkey
-            if (typeof button.hotkey !== undefined) {
+            if (typeof button.hotkey !== 'undefined') {
                 this.registeredButtonHotkeys[button.hotkey] = $button;
             }
 

diff --git a/examples/assets/bootstrap-dialog/js/bootstrap-dialog.min.js b/examples/assets/bootstrap-dialog/js/bootstrap-dialog.min.js
diff --git a/js/bootstrap-dialog.js b/js/bootstrap-dialog.js
@@ -468,24 +468,24 @@
             $button.prop('id', button.id);
 
             // Icon
-            if (typeof button.icon !== undefined && $.trim(button.icon) !== '') {
+            if (typeof button.icon !== 'undefined' && $.trim(button.icon) !== '') {
                 $button.append(this.createButtonIcon(button.icon));
             }
 
             // Label
-            if (typeof button.label !== undefined) {
+            if (typeof button.label !== 'undefined') {
                 $button.append(button.label);
             }
 
             // Css class
-            if (typeof button.cssClass !== undefined && $.trim(button.cssClass) !== '') {
+            if (typeof button.cssClass !== 'undefined' && $.trim(button.cssClass) !== '') {
                 $button.addClass(button.cssClass);
             } else {
                 $button.addClass('btn-default');
             }
 
             // Hotkey
-            if (typeof button.hotkey !== undefined) {
+            if (typeof button.hotkey !== 'undefined') {
                 this.registeredButtonHotkeys[button.hotkey] = $button;
             }
 

diff --git a/js/bootstrap-dialog.min.js b/js/bootstrap-dialog.min.js