Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: create shellcheck.yml #739

Merged
merged 12 commits into from
Sep 25, 2023
Merged

chore: create shellcheck.yml #739

merged 12 commits into from
Sep 25, 2023

Conversation

nakamasato
Copy link
Owner

@nakamasato nakamasato commented Sep 25, 2023 •
edited
Loading

rhysd/actionlint#355

actionlint fails with SC2043:warning:1:13: This loop will only ever run once. Bad quoting or missing glob/expansion? because of for file in ${{ steps.changed-files.outputs.shell_all_changed_files }}; do

ignore shellcheck with # shellcheck disable=SC2043

      - name: run shellcheck for all changed shell scripts
        if: steps.changed-files.outputs.shell_any_changed == 'true'
        run: |
          # https://github.com/rhysd/actionlint/issues/355
          # shellcheck disable=SC2043
          for file in ${{ steps.changed-files.outputs.shell_all_changed_files }}; do
            echo "$file was changed"
            shellcheck "$file"
          done

@github-actions
Copy link
Contributor

hello

@github-actions github-actions bot mentioned this pull request Sep 25, 2023
Merged
@github-actions
Copy link
Contributor

hello

@github-actions
Copy link
Contributor

hello

@github-actions
Copy link
Contributor

hello

@github-actions
Copy link
Contributor

hello

@github-actions
Copy link
Contributor

hello

@github-actions
Copy link
Contributor

hello

@github-actions
Copy link
Contributor

hello

@github-actions
Copy link
Contributor

hello

@github-actions
Copy link
Contributor

hello

@github-actions
Copy link
Contributor

hello

@github-actions
Copy link
Contributor

hello

@github-actions
Copy link
Contributor

Add release label if you want to release when this pull request is merged. (Mon Sep 25 2023 12:39:08 GMT+0000 (Coordinated Universal Time)) keep-only-one-comment-on-pr.yml

@nakamasato nakamasato marked this pull request as ready for review September 25, 2023 12:40
@nakamasato nakamasato merged commit b365831 into main Sep 25, 2023
37 checks passed
@nakamasato nakamasato deleted the nakamasato-patch-2 branch September 25, 2023 12:41
@github-actions
Copy link
Contributor

GitHub Actions has been triggered: https://github.com/nakamasato/github-actions-practice/actions/runs/6299505229

@github-actions
Copy link
Contributor

PR has been merged. we're processing it! (Mon Sep 25 2023 12:41:37 GMT+0000 (Coordinated Universal Time))

@github-actions
Copy link
Contributor

Draft release (122441048) has been created. (Mon Sep 25 2023 12:41:39 GMT+0000 (Coordinated Universal Time))

@github-actions
Copy link
Contributor

Pull Request

Please merge the PR #714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nakamasato nakamasato

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nakamasato