bugfix #9
Open
bugfix #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use_https from from function call was not taken to account in forming s3HTTP request. Resulted in error: 'Client sent an HTTP request to an HTTPS server.' I changed s3HTTP(...use_https = FALSE) to s3HTTP(...use_https = use_https).
BugFix get_bucket.R for use_https
…nly be used for arguments, as this arguments were not given before, fix was also proposed by vstathias
Bugfixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had problems to using "get_bucket" from your nice package together with an https-server. Error: 'Client sent an HTTP request to an HTTPS server. Seems that "use_https" parameter in function call is not used in forming the request for s3http() request. Changed use_https = FALSE to use_https = use_https and now the package works for me. Seems that in other functions this is already implemented like this.
Best regards
Rikard