Prevent addSystem/removeSystem during update #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense to me, however it's not implemented in upstream (original ash) and technically this is a breaking change, because there might be some weird cases when one wants to insert a system into update loop so that it's executed in current iteration... |
|
You are right it should not differ from the original Ash |
|
Yeah I think the official word from Richard Lord, if I'm reading this issue correctly: richardlord/Ash#39, is to just use updateComplete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I had very weird and hard-to-debug issues when I was not using the updateComplete signal.
So I think it should be forbidden to add or remove systems during the engine update.
What do you think?